Fix RSpec/VerifiedDoubles
cop (#25469)
This commit is contained in:
parent
38433ccd0b
commit
05f9e39b32
50 changed files with 162 additions and 172 deletions
|
@ -6,7 +6,7 @@ RSpec.describe Account::Field do
|
|||
describe '#verified?' do
|
||||
subject { described_class.new(account, 'name' => 'Foo', 'value' => 'Bar', 'verified_at' => verified_at) }
|
||||
|
||||
let(:account) { double('Account', local?: true) }
|
||||
let(:account) { instance_double(Account, local?: true) }
|
||||
|
||||
context 'when verified_at is set' do
|
||||
let(:verified_at) { Time.now.utc.iso8601 }
|
||||
|
@ -28,7 +28,7 @@ RSpec.describe Account::Field do
|
|||
describe '#mark_verified!' do
|
||||
subject { described_class.new(account, original_hash) }
|
||||
|
||||
let(:account) { double('Account', local?: true) }
|
||||
let(:account) { instance_double(Account, local?: true) }
|
||||
let(:original_hash) { { 'name' => 'Foo', 'value' => 'Bar' } }
|
||||
|
||||
before do
|
||||
|
@ -47,7 +47,7 @@ RSpec.describe Account::Field do
|
|||
describe '#verifiable?' do
|
||||
subject { described_class.new(account, 'name' => 'Foo', 'value' => value) }
|
||||
|
||||
let(:account) { double('Account', local?: local) }
|
||||
let(:account) { instance_double(Account, local?: local) }
|
||||
|
||||
context 'with local accounts' do
|
||||
let(:local) { true }
|
||||
|
|
|
@ -15,7 +15,7 @@ RSpec.describe AccountMigration do
|
|||
before do
|
||||
target_account.aliases.create!(acct: source_account.acct)
|
||||
|
||||
service_double = double
|
||||
service_double = instance_double(ResolveAccountService)
|
||||
allow(ResolveAccountService).to receive(:new).and_return(service_double)
|
||||
allow(service_double).to receive(:call).with(target_acct, anything).and_return(target_account)
|
||||
end
|
||||
|
@ -29,7 +29,7 @@ RSpec.describe AccountMigration do
|
|||
let(:target_acct) { 'target@remote' }
|
||||
|
||||
before do
|
||||
service_double = double
|
||||
service_double = instance_double(ResolveAccountService)
|
||||
allow(ResolveAccountService).to receive(:new).and_return(service_double)
|
||||
allow(service_double).to receive(:call).with(target_acct, anything).and_return(nil)
|
||||
end
|
||||
|
|
|
@ -16,7 +16,7 @@ RSpec.describe SessionActivation do
|
|||
allow(session_activation).to receive(:detection).and_return(detection)
|
||||
end
|
||||
|
||||
let(:detection) { double(id: 1) }
|
||||
let(:detection) { instance_double(Browser::Chrome, id: 1) }
|
||||
let(:session_activation) { Fabricate(:session_activation) }
|
||||
|
||||
it 'returns detection.id' do
|
||||
|
@ -30,7 +30,7 @@ RSpec.describe SessionActivation do
|
|||
end
|
||||
|
||||
let(:session_activation) { Fabricate(:session_activation) }
|
||||
let(:detection) { double(platform: double(id: 1)) }
|
||||
let(:detection) { instance_double(Browser::Chrome, platform: instance_double(Browser::Platform, id: 1)) }
|
||||
|
||||
it 'returns detection.platform.id' do
|
||||
expect(session_activation.platform).to be 1
|
||||
|
|
|
@ -62,7 +62,7 @@ RSpec.describe Setting do
|
|||
|
||||
context 'when RailsSettings::Settings.object returns truthy' do
|
||||
let(:object) { db_val }
|
||||
let(:db_val) { double(value: 'db_val') }
|
||||
let(:db_val) { instance_double(described_class, value: 'db_val') }
|
||||
|
||||
context 'when default_value is a Hash' do
|
||||
let(:default_value) { { default_value: 'default_value' } }
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue